Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app split #194

Closed
wants to merge 3 commits into from
Closed

app split #194

wants to merge 3 commits into from

Conversation

janmazak
Copy link
Collaborator

No description provided.

@janmazak janmazak force-pushed the appsplit branch 5 times, most recently from 2176b9b to 3832914 Compare June 26, 2023 11:46
@janmazak janmazak changed the title Appsplit app split Aug 15, 2023
@janmazak janmazak marked this pull request as ready for review September 6, 2023 12:23
davidmisiak
davidmisiak reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@davidmisiak davidmisiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the code changes and tried to look for missed modifications.

I haven't performed any manual testing - let me know if I should.

src/nativeScriptHashBuilder_test.c Outdated Show resolved Hide resolved
src/signTx_ui.c Outdated Show resolved Hide resolved
src/txHashBuilder.c Outdated Show resolved Hide resolved
src/signTx.h Outdated Show resolved Hide resolved
src/addressUtilsByron.h Outdated Show resolved Hide resolved
src/addressUtilsByron.h Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
src/signTxPoolRegistration.c Outdated Show resolved Hide resolved
@janmazak janmazak force-pushed the appsplit branch 4 times, most recently from 34d6762 to 227070e Compare October 4, 2023 21:09
@janmazak janmazak requested a review from davidmisiak October 5, 2023 17:32
@janmazak janmazak force-pushed the appsplit branch 2 times, most recently from 7d6b84d to b6caa15 Compare October 6, 2023 09:52
davidmisiak
davidmisiak approved these changes Oct 9, 2023
View reviewed changes
src/uiScreens_bagl.c Show resolved Hide resolved
@janmazak janmazak force-pushed the appsplit branch 2 times, most recently from 016794e to 7f80101 Compare November 29, 2023 22:46
@janmazak
Copy link
Collaborator Author

part of #208 now

@janmazak janmazak closed this Dec 19, 2023
@janmazak janmazak deleted the appsplit branch January 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmisiak davidmisiak davidmisiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmazak @davidmisiak