feat(solana): more generic transaction parsing #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielKerekes
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Nice! Seems to work well 🙂 @PeterBenc I don't think you need to review this too - if you want to, feel free to ofc, just let us know if we can create a PR to Trezor repo or if we should wait for your review 🙏
MartinZemanik
force-pushed
the
solana-more-generic-transaction-parsing
branch
from
62e7d4b to
aa3855e
Compare
MartinZemanik
force-pushed
the
solana-more-generic-transaction-parsing
branch
from
5793531 to
d5f5517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parsing transaction token effects
Before, all Solana transaction token effects were parsed only based on Token transfer instructions - if there were no token transfer instructions directly in the tx, no token effects would be parsed.
Now, we also consider all inner instructions in the transaction. This way, we have a generic parser for token effects on all user's token accounts.
Unknown transactions
Before, if the transaction wasn't a direct token or SOL transfer, it would be interpreted as
unknown.Now, if a transaction contains some instruction in a 3rd party program, it is interpreted as
contracttransaction (as agreed on Slack).Screenshots:
Swap USDC to USDT on Raydium (previously Unknown transaction with no token effects):
