Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ref pkgs (cert-manager v1.16.2) #80

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

halittiryaki
Copy link
Contributor

Includes:

  • go 1.23
  • k8s api 0.31.4

#79

@ibotty
Copy link
Collaborator

ibotty commented Jan 5, 2025

lgtm. There are a few more indirect dependencies, that I can't vet, but a cursory look does not reveal problems.

Includes:

- go 1.23
- k8s api 0.31.4
@halittiryaki
Copy link
Contributor Author

halittiryaki commented Jan 5, 2025

lgtm. There are a few more indirect dependencies, that I can't vet, but a cursory look does not reveal problems.

sorry, noob in go..

locally, golangci-lint did not find any issue beside the line `dns "github.com/cert-manager/cert-manager/test/acme".

I guess the other errors in github actions were because of the golangci-lint.yml not properly updated.

both issues should be now fixed with the updated commit.

@halittiryaki
Copy link
Contributor Author

pushed another commit for the failing two actions, as seperate commit because I am not sure if it will solve all issues. might need to update it.

  • Lint and Test Charts
  • Lint Code Base

@ibotty
Copy link
Collaborator

ibotty commented Jan 5, 2025

Sorry, I am also not very fluent in Go. Thank you for you efforts!

@halittiryaki
Copy link
Contributor Author

Tapped on a minefield on this one :)

will continue this week when ever i have time.

btw, do you know more why step create kind cluster is skipped in workflow Lint and Test Charts?
without the test cluster working, that workflow can be disabled entirely.

@ibotty
Copy link
Collaborator

ibotty commented Jan 5, 2025

No, I have not looked at the CI at all before.

@halittiryaki
Copy link
Contributor Author

@ibotty please retry ci

@ibotty
Copy link
Collaborator

ibotty commented Feb 6, 2025

Thank you for your efforts. Let's see whether everything is alright now.

@halittiryaki
Copy link
Contributor Author

pushed next update. lets see what issue is still left

@halittiryaki
Copy link
Contributor Author

increased timeout to 30m also in .github/workflows/superlinter.yml like .github/workflows/golangci-lint.yml

if the issue still persists, I suggest disabling the go linting in superlinter by:

VALIDATE_GO: false
VALIDATE_GO_MODULES: false

@vadimkim
Copy link
Owner

vadimkim commented Feb 9, 2025

Looks good. Lint codebase error has 403. Probably connected to anonymous building. Let's try...

@vadimkim vadimkim merged commit c6e7614 into vadimkim:master Feb 9, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants