skip variant test for version before 24

vahid-sohrabloo · Feb 25, 2024 · 7996982 · 7996982
1 parent 0ae6377
commit 7996982
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -18,7 +18,7 @@ jobs:
     steps:
     - uses: vahid-sohrabloo/clickhouse-action@v1
       with:
-        version: '23.9'
+        version: '24.1'
 
 
     - name: Set up Go
@@ -41,10 +41,11 @@ jobs:
     strategy:
       matrix:
         golang-version: [1.21, 1.22]
-        clickhouse-version: ['23.9', '23.8', '23.7', '22.3', '22.8']
+        clickhouse-version: [''24.1'', '23.10',','23.9', '23.8', '23.7']
     env:
       VERBOSE: 1
       GOFLAGS: -mod=readonly
+      CLICKHOUSE_VERSION: ${{ matrix.clickhouse-version }}
 
     steps:
     - uses: vahid-sohrabloo/clickhouse-action@v1

diff --git a/column/variant_test.go b/column/variant_test.go
@@ -25,6 +25,9 @@ func TestVariant(t *testing.T) {
 	conn, err := chconn.Connect(context.Background(), connString)
 	require.NoError(t, err)
 
+	if conn.ServerInfo().MajorVersion < 24 && conn.ServerInfo().MinorVersion < 1 {
+		t.Skipf("clickhouse-server version %d.%d does not support Variant type", conn.ServerInfo().MajorVersion, conn.ServerInfo().MinorVersion)
+	}
 	err = conn.Exec(context.Background(),
 		fmt.Sprintf(`DROP TABLE IF EXISTS test_%s`, tableName),
 	)