Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added black to pre-commit config; #75

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

valayDave
Copy link
Owner

@valayDave valayDave commented Mar 9, 2023

Proposed change

Add black PC hook to lint and format the code. Will actually run the formater once we merge #74

How to test the change

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • Changelog has been updated to reflect changes

rev: 22.3.0
hooks:
- id: black
language_version: python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Not seen this used before when hooking it up

@@ -19,3 +19,8 @@ repos:
rev: 5.12.0
hooks:
- id: isort
- repo: https://github.com/ambv/black
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- repo: https://github.com/ambv/black
- repo: https://github.com/psf/black

Isn't this the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants