Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definition for ChatMessage and CommandExecution #30

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Update definition for ChatMessage and CommandExecution #30

merged 2 commits into from
Sep 7, 2022

Conversation

dyc3
Copy link
Collaborator

@dyc3 dyc3 commented Sep 7, 2022 •
edited
Loading

fixes #24

I went ahead and updated CommandExecution too since these 2 packets are similar.

Test plan

  1. run cargo r -r --example terrain
  2. run mc and join localhost
  3. type any non command in chat
  4. type /help in chat
  5. see that you don't get kicked

@dyc3 dyc3 marked this pull request as ready for review September 7, 2022 12:52
@dyc3 dyc3 changed the title Update definition for ChatMessage Update definition for ChatMessage and CommandExecution Sep 7, 2022
@rj00a rj00a merged commit 2b3794d into valence-rs:main Sep 7, 2022
@rj00a
Copy link
Member

rj00a commented Sep 7, 2022

Nice work

@dyc3 dyc3 deleted the chat-no-kick branch September 7, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing in chat causes client to disconnect
2 participants
@dyc3 @rj00a