NBT Tweaks #522

rj00a · 2023-09-05T13:49:01Z

Objective

valence_nbt could use some adjustments.

Move top-level conversion functions to conv module.
Remove public Display impl from Tag.
Remove implicit "null" byte check when decoding compounds. This check can be done in advance if desired.
Remove potentially dangerous memory preallocation when decoding binary.
Make Compound::to_binary and Compound::from_binary free functions for discoverability and familiarity with serde_json.

…tions free for discoverability reasons

rj00a added 8 commits September 5, 2023 17:49

Remove potentially dangerous memory preallocation when decoding binary

a8ccf83

Move conversion functions to conv module

8c87519

Make Tag type more private

6937910

Remove implicit "null" check while decoding, make to/from_binary func…

18bf857

…tions free for discoverability reasons

Changes to valence_anvil

a58a7bf

fmt

13b798a

Fix broken doc link

f008bd9

Add null compound check in Decode impl of Compound

44fc46f

rj00a force-pushed the nbt-tweaks branch from 43418e7 to 44fc46f Compare September 6, 2023 00:49

rj00a enabled auto-merge (squash) September 6, 2023 00:50

rj00a merged commit 1ddde71 into main Sep 6, 2023
10 checks passed

rj00a deleted the nbt-tweaks branch September 6, 2023 01:06