Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extractor 1.21 #635

Closed
wants to merge 3 commits into from
Closed

Extractor 1.21 #635

wants to merge 3 commits into from

Conversation

Bafbi
Copy link
Contributor

@Bafbi Bafbi commented Jul 24, 2024 •
edited
Loading

Objective

Having the extractor upgrade for 1.21

Solution

The extractor is runnable but with some difference in the generated files :

  • The codex is no longer generated until I find how
  • same for paintings and enchants but they were not used
  • the packets file structure have changed

@dyc3
Copy link
Collaborator

dyc3 commented Aug 3, 2024

It looks like the "Build Extractor" CI job needs to be updated

@JackCrumpLeys
Copy link
Contributor

@dyc3 @Bafbi this should be closed in light of #641 being merged

@dyc3 dyc3 closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bafbi @dyc3 @JackCrumpLeys