Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django-active-link 0.2.0 #127

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Django-active-link 0.2.0 #127

merged 12 commits into from
Jun 7, 2024

Conversation

Frodothedwarf
Copy link
Collaborator

0.2.0 (2024-06-06)
+++++++++++++++++
Breaking changes

  • Update build tools to be using Poetry.
  • Dropped support for old Django versions, now officially supporting only: Django 4.0, 4.1, 4.2, 5.0.
  • Fixed bug where kwargs was not sent to reverse function.

Switched to using Poetry instead.
Reasoning for using Poetry is that it is very easy to get up and running on new machines.

@valerymelou can you please look this update through and confirm that the PyPi action is working?
Please note it is my first time using Github Actions 🗡️

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.81%. Comparing base (55e4fc2) to head (b8c07da).
Report is 67 commits behind head on master.

Files Patch % Lines
active_link/templatetags/active_link_tags.py 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   86.48%   94.81%   +8.32%     
==========================================
  Files           3        6       +3     
  Lines          37      135      +98     
  Branches        8       13       +5     
==========================================
+ Hits           32      128      +96     
  Misses          4        4              
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Frodothedwarf Frodothedwarf mentioned this pull request Jun 6, 2024
Copy link
Owner

@valerymelou valerymelou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this @Frodothedwarf

@valerymelou valerymelou merged commit 824ebfe into master Jun 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants