Skip to content

Commit

Permalink
Merge pull request #289 from mbaldessari/quick-fixes
Browse files Browse the repository at this point in the history
A couple of fixes
  • Loading branch information
mbaldessari authored Nov 6, 2024
2 parents 2b3fb5b + 2eaa625 commit fa2c231
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 141 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
{{- range $i := .Values.bucketSecrets }}
{{/*
We fetch the secrets of the s3 buckets called pipeline-bucket and user-bucket
from the ml-development namespace. Then we extract them in a more extended form
into their corresponding aws-connection-user-bucket and aws-connection-pipeline-bucket
and these two aws-connection-* secrets are replicated in ml-development and ml-test
namespaces
*/}}
{{- range $i := list "pipeline-bucket" "user-bucket" }}
---
apiVersion: external-secrets.io/v1alpha1
kind: PushSecret
Expand Down Expand Up @@ -28,12 +35,13 @@ spec:
secret:
name: {{ $i }}
updatePolicy: Replace
{{- range $j := list "ml-development" "manuela-tst-all" }}
---
apiVersion: "external-secrets.io/v1beta1"
kind: ExternalSecret
metadata:
name: s3-{{ $i }}
namespace: ml-development
namespace: {{ $j }}
spec:
refreshInterval: 15s
secretStoreRef:
Expand Down Expand Up @@ -67,3 +75,4 @@ spec:
key: "pushsecrets/{{ $i }}"
property: "AWS_ACCESS_KEY_ID"
{{- end }}
{{- end }}
4 changes: 0 additions & 4 deletions charts/datacenter/data-science-project/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ secretStore:
name: vault-backend
kind: ClusterSecretStore

bucketSecrets:
- pipeline-bucket
- user-bucket

s3:
default_endpoint: http://s3.openshift-storage.svc
default_region: none
Expand Down
6 changes: 0 additions & 6 deletions charts/datacenter/opendatahub/Chart.yaml

This file was deleted.

This file was deleted.

This file was deleted.

20 changes: 0 additions & 20 deletions charts/datacenter/opendatahub/templates/odh-dashboard.yaml

This file was deleted.

73 changes: 0 additions & 73 deletions charts/datacenter/opendatahub/templates/odh-kfdef.yaml

This file was deleted.

2 changes: 0 additions & 2 deletions charts/datacenter/opendatahub/values.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions values-datacenter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ clusterGroup:
jsonPointers:
- /spec/loggingCA

#odh:
#name: odh
#namespace: manuela-ml-workspace
#project: datacenter
#path: charts/datacenter/opendatahub

pipelines:
name: pipelines
namespace: manuela-ci
Expand Down

0 comments on commit fa2c231

Please sign in to comment.