Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds-pipeline-config fixes and url fixes #291

Merged
merged 2 commits into from
Nov 7, 2024
Merged

ds-pipeline-config fixes and url fixes #291

merged 2 commits into from
Nov 7, 2024

Conversation

mbaldessari
Copy link
Contributor

  • Switch notebook to use ds-pipeline-config-custom
  • Drop apps. from urls as localClusterDomain includes it

@mbaldessari
Switch notebook to use ds-pipeline-config-custom
ae29b7b 
The Jupyter notebook is configured to bind-mount this
`ds-pipeline-config` secret. The problem is that this secret gets only
generate if you log into the RHOAI dashboard, go to data science
projects and choose the `ml-development` namespace.

Since this secret contains things that we already know, let's just
create another identical one. The RHOAI dashboard created one looks like
this:

    $ oc extract -n ml-development secrets/ds-pipeline-config --to=- --keys=odh_dsp.json 2>/dev/null | jq .
    {
      "display_name": "Data Science Pipeline",
      "metadata": {
        "tags": [],
        "display_name": "Data Science Pipeline",
        "engine": "Argo",
        "auth_type": "KUBERNETES_SERVICE_ACCOUNT_TOKEN",
        "api_endpoint": "https://ds-pipeline-dspa-ml-development.apps.mcg-hub.aws.validatedpatterns.io",
        "public_api_endpoint": "https://rhods-dashboard-redhat-ods-applications.apps.mcg-hub.aws.validatedpatterns.io/experiments/ml-development",
        "cos_auth_type": "KUBERNETES_SECRET",
        "cos_secret": "aws-connection-pipeline-bucket",
        "cos_endpoint": "http://s3.openshift-storage.svc.cluster.local",
        "cos_bucket": "pipeline-bucket",
        "cos_username": "..",
        "cos_password": "..",
        "runtime_type": "KUBEFLOW_PIPELINES"
      },
      "schema_name": "kfp"
    }

The one we create here will have this content:

    $ oc extract -n ml-development secrets/ds-pipeline-config-custom --to=- --keys=odh_dsp.json 2>/dev/null | jq .
    {
      "display_name": "Data Science Pipeline",
      "metadata": {
        "tags": [],
        "display_name": "Data Science Pipeline",
        "engine": "Argo",
        "auth_type": "KUBERNETES_SERVICE_ACCOUNT_TOKEN",
        "api_endpoint": "https://ds-pipeline-dspa-ml-development.apps.mcg-hub.aws.validatedpatterns.io",
        "public_api_endpoint": "https://rhods-dashboard-redhat-ods-applications.apps.mcg-hub.aws.validatedpatterns.io/experiments/ml-development/",
        "cos_auth_type": "KUBERNETES_SECRET",
        "cos_secret": "aws-connection-pipeline-bucket",
        "cos_endpoint": "http://s3.openshift-storage.svc.cluster.local",
        "cos_bucket": "pipeline-bucket",
        "cos_username": "..",
        "cos_password": "../TXbWAnPebRI4r1ICKQ/tZn8O6U",
        "runtime_type": "KUBEFLOW_PIPELINES"
      },
      "schema_name": "kfp"
    }
@mbaldessari
Drop apps. from urls as localClusterDomain includes it
2caf5cd
@mbaldessari mbaldessari merged commit ef8b550 into validatedpatterns:wip-next-gen Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbaldessari