Fix some issues with the sensor test #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make sure we use the base64-decoded strings from the gitea_admin
secret (for both username and password)
2. If we're unable to fetch from the gitea remote, error out and explain
why
3. Also error out properly when git push fails
4. Also remove the gitea-qe remote everytime to make this more
idempotent
With these changes I was able to get it passing again:
test_toggle_machine_sensor.py::test_toggle_machine_sensor PASSED [100%]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we use the base64-decoded strings from the gitea_admin
secret (for both username and password)
If we're unable to fetch from the gitea remote, error out and explain
why
Also error out properly when git push fails
Also remove the gitea-qe remote everytime to make this more
idempotent
With these changes I was able to get it passing again: