Add storage overrides for different clouds #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helm variable `global.datacenter.storageClassName` is used by the ODF chart to pick the storage class for its storageclass. It defaults to `gp3-csi` which only exists in AWS. Let's add three overrides for the major clouds, picking the right storageclass for that cloud. Also add one for the AWS one just to make things more explicit. Reported-By: Mark Labonte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm variable
global.datacenter.storageClassNameis used by theODF chart to pick the storage class for its storageclass.
It defaults to
gp3-csiwhich only exists in AWS.Let's add three overrides for the major clouds, picking the right
storageclass for that cloud. Also add one for the AWS one just to make
things more explicit.
Reported-By: Mark Labonte [email protected]