reader: partly restore the previous behaviour #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.0.0 changed the way sets and maps are handled in libvalkey-py. Now, all the sets and dicts were treated as lists, maps being lists of tuples. This change was done without keeping `valkey-py` in mind. As it turned out, this way of handling maps is not really applicable to `valkey-py` because `valkey-py` doesn't know what data type it expects. Hence, it can't tell whether the returned list should be treated as a map or left as it is. This commit partly reverts the behaviour to what it was pre-3.0.0, leaving maps as dicts all the time. All sets, though, are being treated as lists now when `convertSetsToLists=True`. While this behaviour excludes some exotic use cases allowed by RESP like set or array being a key of a map, it does not affect the consumer library as much, and none of such exotic use cases are being used in the real world anyway. Signed-off-by: Mikhail Koviazin <[email protected]>
ahmedsobeh
approved these changes
Aug 2, 2024
aiven-sal
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0 changed the way sets and maps are handled in libvalkey-py. Now, all the sets and dicts were treated as lists, maps being lists of tuples. This change was done without keeping
valkey-pyin mind. As it turned out, this way of handling maps is not really applicable tovalkey-pybecausevalkey-pydoesn't know what data type it expects. Hence, it can't tell whether the returned list should be treated as a map or left as it is.This commit partly reverts the behaviour to what it was pre-3.0.0, leaving maps as dicts all the time. All sets, though, are being treated as lists now when
convertSetsToLists=True. While this behaviour excludes some exotic use cases allowed by RESP like set or array being a key of a map, it does not affect the consumer library as much, and none of such exotic use cases are being used in the real world anyway.