MANIFEST: add exported headers directory #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hiredis was forked to libvalkey, it changed its layout to have a proper `src` and `include` directories. Upon forking hiredis-py to libvalkey-py, `include` directory was missing from the source package which means the module could not be built from the sdist package. This issue was hidden by the fact that all the supported systems were provided with a binary package hence noone actually needed to build it. This was revealed when people started using libvalkey-py with Python 3.13 that was missing a binary package. This commit fixes this bug by adding `include` directory to MANIFEST.in Fixes valkey-io#19 Signed-off-by: Mikhail Koviazin <[email protected]>
aiven-sal
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hiredis was forked to libvalkey, it changed its layout to have a proper
srcandincludedirectories. Upon forking hiredis-py to libvalkey-py,includedirectory was missing from the source package which means the module could not be built from the sdist package. This issue was hidden by the fact that all the supported systems were provided with a binary package hence noone actually needed to build it.This was revealed when people started using libvalkey-py with Python 3.13 that was missing a binary package.
This commit fixes this bug by adding
includedirectory to MANIFEST.inFixes #19