RDMA bind local address #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizhenwei
force-pushed
the
rdma-bind-addr
branch
from
9314f6f to
7ff33d1
Compare
bjosv
approved these changes
Oct 29, 2024
michael-grunder
approved these changes
Oct 29, 2024
Use RDMA style function instead of inet style for getting address. Also simplify error handling. Signed-off-by: zhenwei pi <[email protected]>
Like TCP, it's possible to bind a specific address for client side. Currently, RDMA binding local address is supported by test program manually. Signed-off-by: zhenwei pi <[email protected]>
"Resource temporarily unavailable" is required by client_test program, use the same log meesage for RDMA. Signed-off-by: zhenwei pi <[email protected]>
Since a7cbca40661("RDMA: Support .is_local method (#1089)"), valkey
starts to support local connection. Valkey server and client run on a
single server, protected mode is not required.
Signed-off-by: zhenwei pi <[email protected]>
pizhenwei
force-pushed
the
rdma-bind-addr
branch
from
7ff33d1 to
3a9cf55
Compare
|
Hi @michael-grunder |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @michael-grunder @bjosv
Each patch has independent functionality, also been tested by CI and local commands, so request no-squash merge for this PR.