Refactor the parsing of a key in a command #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
The number of elements in the array of keys is either one or none in the command struct. Remove the array and refactor the code. Use the length of the keypos to determine if found. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Jul 1, 2024
| @@ -36,12 +36,9 @@ | |||
| #include <stdint.h> | |||
| #include <sys/types.h> | |||
|
|
|||
| #define VK_OK 0 | |||
| #define VK_ERROR -1 | |||
| #define VK_EAGAIN -2 | |||
There was a problem hiding this comment.
How come OK is deleted by the errors remain? Does any function return OK | ERROR?
There was a problem hiding this comment.
There is no use of VK_ERROR in src/, only VK_OK.
The plan was to remove a lot of unused code in a separate PR. This is now done in #41.
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
The number of elements in the array of keys is either one or none in the command struct, so this change removes the array and refactors the code. Additional changes: - Remove `vkarray.c/.h` - Remove unused `remain_len` from `struct keypos` - Remove unused `remain_len` from `struct keypos` - Remove unused `reply` from `struct cmd` - Remove unused `quit` and `noforward` from `struct cmd` - Remove unused command `type` from `struct cmd` - Remove unused `id` from `struct cmd` - Remove unused `narg` from `struct cmd` - Remove unused `frag_seq` from `struct cmd` Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of elements in the array of keys is either one or none in the command struct.
Remove the array and refactor the code after #23 was merged.
Additional changes:
vkarray.c/.hremain_lenfromstruct keyposremain_lenfromstruct keyposreplyfromstruct cmdquitandnoforwardfromstruct cmdtypefromstruct cmdidfromstruct cmdnargfromstruct cmdfrag_seqfromstruct cmd