Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: JSON commands in transaction #2691

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Java: JSON commands in transaction #2691

merged 2 commits into from
Nov 18, 2024

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Nov 14, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2683

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@jamesx-improving jamesx-improving requested a review from a team as a code owner November 14, 2024 20:09
@yipin-chen
Copy link
Collaborator

yipin-chen commented Nov 14, 2024 •
edited
Loading

Don't forget to add MGET command and update CHANGELOG.

@jamesx-improving jamesx-improving changed the base branch from release-1.2 to feature/module-transaction November 15, 2024 19:55
@acarbonetto acarbonetto mentioned this pull request Nov 16, 2024
Open
6 tasks
acarbonetto
acarbonetto approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@jamesx-improving
Copy link
Collaborator Author

image
image

@jamesx-improving jamesx-improving merged commit 25c7f83 into feature/module-transaction Nov 18, 2024
8 of 9 checks passed
@jamesx-improving jamesx-improving deleted the java/jamesx-json-transaction branch November 18, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesx-improving @yipin-chen @acarbonetto @prateek-kumar-improving