Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORT rework for 1.2 #2706

Merged
merged 1 commit into from
Nov 18, 2024
Merged

ORT rework for 1.2 #2706

merged 1 commit into from
Nov 18, 2024

Conversation

ikolomi
Copy link
Collaborator

@ikolomi ikolomi commented Nov 18, 2024

  1. Added ort-sweeper workflow that triggers periodic (once a day) ORT runs for branches main and release-*
  2. Fixed ORT invocation for glide-core/redis-rs by creating a virtual workspace
  3. Updated license-generating script to prevent the creation of unapproved_package_list.txt file for unapproved/unknown licenses
  4. Configured ORT checker workflow to run on each pull request without file filters, producing warnings if licenses need to be updated
  5. TODO: Modify ORT checker to fail pull requests introducing unapproved/unknown licenses, deferred until unsupported licenses are removed to avoid blocking PRs
  6. Added support to trigger the ORT checker manually with a specified target branch

Issue link

This Pull Request is linked to issue (URL): #2531

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • [ ] Tests are added or updated.
  • [ ] CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

1. Added ort-sweeper workflow that triggers periodic (once a day) ORT runs for branches main and release-*
2. Fixed ORT invocation for glide-core/redis-rs by creating a virtual workspace
3. Updated license-generating script to prevent the creation of unapproved_package_list.txt file for unapproved/unknown licenses
4. Configured ORT checker workflow to run on each pull request without file filters, producing warnings if licenses need to be updated
5. TODO: Modify ORT checker to fail pull requests introducing unapproved/unknown licenses, deferred until unsupported licenses are removed to avoid blocking PRs
6. Added support to trigger the ORT checker manually with a specified target branch

Signed-off-by: ikolomi <[email protected]>
Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue for updating the versions.

@ikolomi ikolomi merged commit b8dc6a5 into release-1.2 Nov 18, 2024
13 checks passed
@ikolomi ikolomi deleted the ort-rework-for-1.2 branch November 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants