Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: XGROUP DESTROY. #2974

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Go: XGROUP DESTROY. #2974

merged 8 commits into from
Jan 21, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Jan 17, 2025 •
edited
Loading

Based on #2966

Issue link

This Pull Request is linked to issue (URL): #2968

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Yury-Fridlyand
Go: XGROUP CREATE.
ca8e8ad 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
fix test.
bc88940 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Go: XGROUP DESTROY.
1f98bb9 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Jan 17, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner January 17, 2025 22:50
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jan 17, 2025
Closed
5 tasks
@Yury-Fridlyand Yury-Fridlyand changed the title Go: XGROUP CREATE. Go: XGROUP DESTROY. Jan 17, 2025
jbrinkman
jbrinkman approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand merged commit 2990264 into valkey-io:main Jan 21, 2025
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/xgroupdestroy branch January 21, 2025 06:23
Maayanshani25 pushed a commit to Maayanshani25/valkey-glide that referenced this pull request Jan 22, 2025
@Yury-Fridlyand @Maayanshani25
Go: XGROUP DESTROY. (valkey-io#2974)
10fb157 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 23, 2025
@Yury-Fridlyand @EdricCua
Go: XGROUP DESTROY. (valkey-io#2974)
710b414 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 23, 2025
@Yury-Fridlyand @EdricCua
Go: XGROUP DESTROY. (valkey-io#2974)
75a3cb7 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
EdricCua pushed a commit to EdricCua/valkey-glide that referenced this pull request Jan 23, 2025
@Yury-Fridlyand @EdricCua
Go: XGROUP DESTROY. (valkey-io#2974)
6195a89 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
eifrah-aws pushed a commit to eifrah-aws/glide-for-redis that referenced this pull request Jan 23, 2025
@Yury-Fridlyand @eifrah-aws
Go: XGROUP DESTROY. (valkey-io#2974)
529fc0e 
* Go: `XGROUP CREATE`.

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@jbrinkman jbrinkman jbrinkman approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @jbrinkman @prateek-kumar-improving