Go: BZPOPMAX and ZMPOP #3017
Open
Go: BZPOPMAX and ZMPOP #3017
+932
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
edlng
reviewed
Feb 3, 2025
edlng
reviewed
Feb 3, 2025
tjzhang-BQ
reviewed
Feb 4, 2025
MikeMwita
force-pushed
the
add-zmpop-and-bzpopmax-imple
branch
from
821c1a1 to
e354de2
Compare
MikeMwita
force-pushed
the
add-zmpop-and-bzpopmax-imple
branch
4 times, most recently
from
7ab8c90 to
cf4fcf2
Compare
MikeMwita
force-pushed
the
add-zmpop-and-bzpopmax-imple
branch
6 times, most recently
from
d3a7fcb to
ae55983
Compare
Signed-off-by: MikeMwita <[email protected]>
MikeMwita
force-pushed
the
add-zmpop-and-bzpopmax-imple
branch
from
ae55983 to
101427f
Compare
| @@ -45,6 +45,10 @@ type SortedSetCommands interface { | |||
| options *options.ZMPopOptions, | |||
| ) (Result[KeyWithArrayOfMembersAndScores], error) | |||
|
|
|||
| BZPopMax(keys []string, timeoutSecs float64) (Result[KeyWithMemberAndScore], error) | |||
|
|
|||
| ZMPop(keys []string, scoreFilter ScoreFilter) (Result[KeyWithArrayOfMembersAndScores], error) | |||
There was a problem hiding this comment.
As mentioned in this comment: #3017 (comment), the count parameter needs to be added in a separate definition as it is optional.
edlng
reviewed
Feb 13, 2025
| @@ -201,6 +201,11 @@ func toCStrings(args []string) ([]C.uintptr_t, []C.ulong) { | |||
| // | |||
| // `"OK"` response on success. | |||
| // | |||
| // For example: | |||
There was a problem hiding this comment.
Remove all these added example comments in base_client.go. We now add examples in the api/*_test.go files.
Comment on lines
+6868
to
+6872
| // Example: | ||
| // | ||
| // zaddResult, err := client.ZAdd("mySortedSet", map[string]float64{"a": 1.0, "b": 2.0, "c": 3.0}) | ||
| // res, err := client.BZPopMax([]string{"mySortedSet"}, 1.0) | ||
| // fmt.Println(res.Value()) // Output: {Key: "mySortedSet", Member: "c", Score: 3.0} |
There was a problem hiding this comment.
Move this to api/sorted_set_commands_test.go instead and create examples for ExampleGlideClient and ExampleGlideClusterClient. Feel free to look at the DEVELOPER.md for more details about the new way to write examples
Comment on lines
+6908
to
+6911
| // Example: | ||
| // | ||
| // res, err := client.ZMPop([]string{"mySortedSet"}, api.MAX, 2) | ||
| // fmt.Println(res.Value()) // Output: {Key: "mySortedSet", MembersAndScores: [{Member: "c", Score: 3.0}, {Member: "b", Score: |
There was a problem hiding this comment.
Move this to api/sorted_set_commands_test.go instead and create examples for ExampleGlideClient and ExampleGlideClusterClient.
Yury-Fridlyand
requested changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue: #2971
Checklist
Before submitting the PR make sure the following are checked: