add linters go vet and staticcheck #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: staticcheck S1021 fix: valkey-io#6 Signed-off-by: Sandor Szücs <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
===========================================
- Coverage 95.59% 23.57% -72.02%
===========================================
Files 81 81
Lines 33405 31400 -2005
===========================================
- Hits 31935 7404 -24531
- Misses 1269 23524 +22255
- Partials 201 472 +271 ☔ View full report in Codecov by Sentry. |
rueian
approved these changes
May 8, 2024
| # -ST1020 violation of go doc comment on exported methods in valkeycompat | ||
| # -ST1021 violation of go doc comment on exported types in valkeycompat | ||
| # -U1000 unused check in mock package | ||
| staticcheck -checks "all,-ST1000,-ST1003,-ST1012,-ST1016,-ST1020,-ST1021,-U1000" ./... | (grep -v "_test.go:" && exit 1 || exit 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6