Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from topic review #71

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

stockholmux
Copy link
Member

@stockholmux stockholmux commented May 24, 2024

Description

A few issues came up while reviewing for publication. valkey-io/valkey-doc#91

  1. the regex was a little greedy and would occasionally eat two markdown links in one and causing a weird edge case where two transforms occur at once. The changes in templates/macros/docs.html fixes resolves this.
  2. The docs repo differs in structure compared to website and calling commands is tricky. This gives an alias to the command listing page to make them play nice.

Update 05/31 (probably should have made the original PR a draft)

  • Added a few more fixes for the URL re-writer
  • Add the bits to allow for suppressing pages that still exist in the docs repo but shouldn't be published (yet/ever).
  • Added the specific pages that need the review warning and to be supressed

Issues Resolved

n/a

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

madolson
madolson previously approved these changes May 28, 2024
@stockholmux stockholmux merged commit b5c2293 into valkey-io:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants