Fixes for valkey 8.0 #124
Merged
Fixes for valkey 8.0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behaviour of READONLY was changed in valkey-io/valkey#325 which became a part of 8.0.0. This caused test_readonly_invalid_cluster_state to fail. This commit takes into account this change. Signed-off-by: Mikhail Koviazin <[email protected]>
Hash commands are part of proprietary module that Valkey does not implement for now. Mark them for skipping just like JSON and search. Signed-off-by: Mikhail Koviazin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 75.17% 75.29% +0.11%
==========================================
Files 132 132
Lines 34480 34496 +16
==========================================
+ Hits 25921 25974 +53
+ Misses 8559 8522 -37 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Previously the test relied on the amount of clients that are currently connected to the server. This is not robust as this can be affected by the outside or a bad timing. This caused quite a lot of test case failures. The proper way to handle this is: * Create a client and assign a distinguishable name to it * Verify it's in `CLIENT LIST` * Sleep for enough time for it to be killed by maxage we provide * Verify it's not anymore in `CLIENT LIST` This commit does exactly that. Signed-off-by: Mikhail Koviazin <[email protected]>
aiven-sal
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
This PR should fix the tests that started failing when running with Valkey 8.0