Print logs when the cluster state changes to fail add cluster_fail_reason to CLUSTER INFO #1188
+86
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes This log allows us to easily distinguish between full coverage and minority partition when the cluster fails. Sometimes it is not easy to see the minority partition in a healthy shards (both primary and replicas). Signed-off-by: Binbin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1188 +/- ##
============================================
+ Coverage 70.47% 70.69% +0.21%
============================================
Files 114 114
Lines 61799 63109 +1310
============================================
+ Hits 43555 44616 +1061
- Misses 18244 18493 +249
|
PingXie
reviewed
Oct 22, 2024
Co-authored-by: Ping Xie <[email protected]> Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
changed the title
enjoy-binbin
added
major-decision-pending
madolson
reviewed
Nov 4, 2024
| @@ -5986,6 +6023,7 @@ sds genClusterInfoString(void) { | |||
|
|
|||
| info = sdscatprintf(info, | |||
| "cluster_state:%s\r\n" | |||
| "cluster_fail_reason:%s\r\n" | |||
There was a problem hiding this comment.
I honestly would rather not add an info field. This is one of those things were if the cluster is down, you get more useful information from the other fields (cluster_slots_assigned and cluster_size) and I don't want to add yet another field to look at. It's also not necessarily one or the other, it could be both.
There was a problem hiding this comment.
yean, this does seem useless, @PingXie thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This log allows us to easily distinguish between full coverage and
minority partition when the cluster fails. Sometimes it is not easy
to see the minority partition in a healthy shards (both primary and
replicas).