Add a non breaking feature for module configs to support validation & rejection of config sets #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rejection of config sets Signed-off-by: Karthik Subbarao <[email protected]>
|
nit: @KarthikSubbarao could you please rebase with PR I just merged run |
dmitrypol
reviewed
Dec 6, 2024
examples/configuration.rs
Outdated
| @@ -61,19 +115,23 @@ valkey_module! { | |||
| configurations: [ | |||
| i64: [ | |||
| ["i64", &*CONFIGURATION_I64, 10, 0, 1000, ConfigurationFlags::DEFAULT, Some(Box::new(on_configuration_changed))], | |||
| ["reject-i64", &*CONFIGURATION_REJECT_I64, 10, 0, 1000, ConfigurationFlags::DEFAULT, Some(Box::new(on_configuration_changed)), Some(Box::new(on_i64_config_set::<ValkeyString, ValkeyGILGuard<i64>>))], | |||
There was a problem hiding this comment.
tiny nit: could you stick to snake_case just to be consistent in all 4 examples
Signed-off-by: Karthik Subbarao <[email protected]>
|
Thank you for helping review this, @dmitrypol. I addressed the comments in this commit: 809af26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a non breaking feature for module configs to support validation & rejection of config sets
Also added integration testing for validation of new functionality and to ensure it is non breaking
Implements #123