Fix infinite loop in dev mode #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamantios
added
cli
We do not want all the matrix jobs to get canceled if one fails.
solarw
reviewed
Feb 18, 2025
OjusWiZard
approved these changes
Feb 18, 2025
Fix the regressed packages' tests [no ci]
Fix the regressed CLI tests [no ci]
Fix `autonomy deploy build` command [no ci]
Adamantios
added a commit
that referenced
this pull request
Feb 18, 2025
- Replaced `while` loop with a `for`, using `itertools.chain` for cleaner iteration over path and parents (#2304 (comment)). - Used `is_file()` instead of `exists()` to explicitly check for `packages.json`. - Improved error message for clarity. - Simplified path resolution by avoiding redundant `Path(path)`.
solarw
approved these changes
Feb 18, 2025
- Replaced `while` loop with a `for`, using `itertools.chain` for cleaner iteration over path and parents (#2304 (comment)). - Used `is_file()` instead of `exists()` to explicitly check for `packages.json`. - Improved error message for clarity. - Simplified path resolution by avoiding redundant `Path(path)`.
Adamantios
force-pushed
the
fix/infinite-loop
branch
from
abcaf0d to
2044a5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore/continue-on-error #2304 +/- ##
==========================================================
Coverage ? 93.13%
==========================================================
Files ? 225
Lines ? 16363
Branches ? 0
==========================================================
Hits ? 15240
Misses ? 1123
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes an infinite loop in the dev mode.
Notice how the CI times out due to the infinite loop on the base and how it fails instead in this PR.
Fixes
n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments
n/a