Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Check samples.tsv with PandasSchema #328

Closed
Maarten-vd-Sande opened this issue May 7, 2020 · 4 comments · Fixed by #467
Closed

FR: Check samples.tsv with PandasSchema #328

Maarten-vd-Sande opened this issue May 7, 2020 · 4 comments · Fixed by #467
Labels
enhancement New feature or request stale Period of inactivity

Comments

@Maarten-vd-Sande
Copy link
Member

Is your feature request related to a problem? Please describe.
See https://github.com/TMiguelT/PandasSchema. Never used it before, but the example seems really nice! Would be much easier to debug a faulty samples.tsv.

@Maarten-vd-Sande Maarten-vd-Sande added the enhancement New feature or request label May 7, 2020
@siebrenf
Copy link
Member

I wanted to simplify how we handle the samples.tsv, especially around replicates and conditions, to reduce the amount of code and checks a bit. I could take this along

@siebrenf siebrenf reopened this May 17, 2020
@stale
Copy link

stale bot commented Jun 14, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale Period of inactivity label Jun 14, 2020
@siebrenf
Copy link
Member

Some options, such as optional columns, are not yet supported. I'll check back again later :)

@stale stale bot removed the stale Period of inactivity label Jun 16, 2020
@stale
Copy link

stale bot commented Jul 14, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the stale Period of inactivity label Jul 14, 2020
@Maarten-vd-Sande Maarten-vd-Sande linked a pull request Aug 11, 2020 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Period of inactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants