pandasschema #467
Merged
pandasschema #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siebrenf
requested changes
Aug 17, 2020
Comment on lines
123
to
131
| column_schema["sample"] = [LeadingWhitespaceValidation(), | ||
| TrailingWhitespaceValidation(), | ||
| IsDistinctValidation(), | ||
| MatchesPatternValidation(allowed_pattern)] | ||
|
|
||
| column_schema["descriptive_name"] = [LeadingWhitespaceValidation(), | ||
| TrailingWhitespaceValidation(), | ||
| IsDistinctValidation(), | ||
| MatchesPatternValidation(allowed_pattern)] |
There was a problem hiding this comment.
all columns are checked in the for loop after this, so maybe make a for loop for these two columns to check the IsDistinceValidation()?
There was a problem hiding this comment.
Yep makes sense!
|
Waiting for this to be accepted: multimeric/PandasSchema#37 |
siebrenf
approved these changes
Aug 17, 2020
siebrenf
reviewed
Aug 17, 2020
Comment on lines
125
to
126
| [Column(col, [MatchesPatternValidation(allowed_pattern), | ||
| IsDistinctValidation(ignore_nan=True)] if col in distinct_columns else [MatchesPatternValidation(allowed_pattern)], allow_empty=True) for col in |
There was a problem hiding this comment.
ignore_nan doesnt exist now right?
There was a problem hiding this comment.
Good catch! The cat 🐱 didnt let me sleep last night
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is the PR solving / What's new?
Added pandasschema for column parsing and slightly prettier/clearer/user-friendliness log for bad public samples (in the sense they all get logged).
@siebrenf I think the same check was done twice or do I not understand?
Checklist