Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try out vapor run-unit-tests [stuck] #2

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

sliemeobn
Copy link
Collaborator

No description provided.

@sliemeobn sliemeobn mentioned this pull request Jul 5, 2024
@MahdiBM MahdiBM marked this pull request as ready for review July 5, 2024 08:15
@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

[It doesn't run for draft PRs, because of the types: [opened, reopened, synchronize, ready_for_review] line 🙂]

@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

ok these failures are not the ones i expected 😅 some kind of compiler bug?!

@sliemeobn
Copy link
Collaborator Author

well.... that went well ; )
seems like hitting a lot of compiler bugs. I think it's the variadic generics that are not quite 100%.
there are a few swift compiler issues on github open for it too - just a guess though.

@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

hmm that helped ...
The API breakage check is disable-able but not sure what to do about Swift 5.10 one. It appears the bug only happens on Ubuntu Noble now?

@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

Nope, this is a dead-end with the Swift 5.10 Noble bug.

@MahdiBM
Copy link

MahdiBM commented Jul 5, 2024

Feel free to close the PR. We can try updating in some months or something I guess.
Or get Gwynne to add a config option to not use 5.10 noble.

@sliemeobn
Copy link
Collaborator Author

thanks for your efforts, I'll park the PR for now, maybe somebody fixes the 5.10 compiler issues eventually.
it's good to see it work on 6.0, so at least we have that going.

@sliemeobn sliemeobn changed the title try out vapor run-unit-tests try out vapor run-unit-tests [stuck] Jul 5, 2024
@sliemeobn sliemeobn marked this pull request as draft July 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants