-
Notifications
You must be signed in to change notification settings - Fork 12
brand register form design #46
base: master
Are you sure you want to change the base?
brand register form design #46
Conversation
<Autocomplete | ||
</Autocomplete> | ||
</div> | ||
<div class="w-full md:w-1/3 px-3 mb-6 md:mb-0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see two arrows for dropdown in this field
{/* <p class="text-red-500 text-xs italic">Please fill out this field.</p> */} | ||
</div> | ||
<div class="w-full md:w-1/2 px-3"> | ||
<label class="block uppercase tracking-wide text-gray-900 text-xs font-bold mb-2" for="grid-last-name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should also be required
<label class="block uppercase tracking-wide text-gray-900 text-xs font-bold mb-2" for="grid-state"> | ||
Instagram Handle | ||
</label> | ||
<div class="relative"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no dropdown arrow in Instagram handle
field
@@ -65,93 +65,123 @@ function SellerBusinessDetailsForm({ formData, setFormData, page }) { | |||
|
|||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could change the theme of the whole form to dark theme, that would be great!
<svg aria-hidden="true" class="mb-3 w-10 h-10 text-gray-400" fill="none" stroke="currentColor" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M7 16a4 4 0 01-.88-7.903A5 5 0 1115.9 6L16 6a5 5 0 011 9.9M15 13l-3-3m0 0l-3 3m3-3v12"></path></svg> | ||
<p class="mb-2 text-sm text-gray-500 dark:text-gray-400"><span class="font-semibold">Click to upload</span></p> | ||
</div> | ||
<input | ||
id="fileInput" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview of brand logo should be slightly bigger
</div> | ||
</div> | ||
</div> | ||
|
||
</section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change the heading of the form Register for sellers
to Brand registration
.
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you could use a different step indicator, that would be great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need of underlined blue headings , you can remove them.
@Sathasivamthirumoorthi Also change your commit message according to the commit conventions and make sure to merge all the commits into one single commit. |
@Sathasivamthirumoorthi Do these changes and after your PR gets merged, comment on issue #43. I will assign it to you. |
@Sathasivamthirumoorthi Please respond |
Working on |
@Sathasivamthirumoorthi when are you planning to update the changes? |
No description provided.