Minor build fixes #4061
Merged
Minor build fixes #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2024 10:02
When a VMOD adds a CFLAG with `libvmod_$1_la_CFLAGS` the object name is no longer `vmod_$name.lo` but `$library-vmod_name.lo` this changes the build order such that the VCC autogenerated files would not be guaranteed to compile first causing compilation issues.
|
I cherry-picked the wflags fix, but would like to leave the rest with @dridi . |
|
Merging as per IRC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit I noticed there was a missing comma in wflags.py
UNDESIRABLE_WFLAGS. The build system didn't seem to care either way but figured it was easy enough to update.The second commit relates to the auto-generated
BUILD_VMOD_$NAMEhelper generated byVARNISH_VMOD()inconfigure.ac. When a VMOD adds a CFLAG withlibvmod_$1_la_CFLAGSthe object name is no longervmod_$name.lobut$library-vmod_name.lothis changes the build order such that the VCC autogenerated files would not be guaranteed to compile first causing compilation issues. Updating to the$libvmod_$1_la_OBJECTSfixes the build order by letting automake/tools figure out the right object name. It might add in more objects than really desired but it's probably better to have the VCC files always built first.Issue found in the wild: varnish/libvmod-curl#56