Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full markdown editor to users/intro page #913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yeputons
Copy link

Partially fixes #619.

I'm not exactly sure what the CSS is doing, but it's copied from what's used by the editor on the profile page and without it the page looks like this:

изображение

This PR looks like this:

изображение

Some other places which may or may not need markdown editor:

  • I was unable to test locally:
    • GodmodeNetworkSettingsEditForm.network_page
    • PostAnnounceForm.text
    • users/forms/admin.py:
      • ban_reason
      • ping
  • Actually need markdown-editor-invisible which never existed in the first place:
    • bio at users/forms/intro.py and users/forms/profile.py

It was only used for comments which are covered by CommentMarkdownEditor.vue
Similar to what's in posts/compose/intro.html
I'm not sure what the copied CSS does, but otherwise a wild horizontal
scroll bar appears in Firefox at the least.
@yeputons yeputons requested a review from vas3k as a code owner February 22, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Фича: показывать превью intro на странице приветствия (/intro)
1 participant