Skip to content

Commit

Permalink
Issue 6099 - systemd = False has no effect
Browse files Browse the repository at this point in the history
Bug Description:
`systemd = False` doesn't override `with_systemd = 1` from
`defaults.inf` when used with `dscreate`. It is only effective when
setup is running in a containerized environment (via `dscontainer`).
But for some special use cases it's important that DS installation runs
without systemd.

Fix Description:
Remove the condition for overriding systemd flag.
`systemd` option is not exposed in the default template, it's listed
there only when `--advanced` flag is used, so it should not affect
regular installations.

Fixes: 389ds#6099
  • Loading branch information
vashirov committed Feb 19, 2024
1 parent 91443ac commit dd6cc54
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/lib389/lib389/instance/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -947,8 +947,8 @@ def _install_ds(self, general, slapd, backends):
# Should I move this import? I think this prevents some recursion
from lib389 import DirSrv
ds_instance = DirSrv(self.verbose, containerised=self.containerised)
if self.containerised:
ds_instance.systemd_override = general['systemd']

ds_instance.systemd_override = general['systemd']

# By default SUSE does something extremely silly - it creates a hostname
# that CANT be resolved by DNS. As a result this causes all installs to
Expand Down

0 comments on commit dd6cc54

Please sign in to comment.