Implement ReadAt and Size for Arc<RandomAccessFile>
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Arc<RandomAccessFile>` is useful because it can be cloned, and `ReadAt` and `Size` are not mutating operations. `SizeCursor<Arc<RandomAccessFile>>` can be cloned and shared across threads and also act like a file with a mutable seek position. A more specific example is creating a `zip::ZipArchive<SizeCursor<Arc<RandomAccessFile>>>` instance and cloning a copy per thread. https://docs.rs/zip/1.1.4/zip/read/struct.ZipArchive.html
Databean
changed the title
ReadAt and Size for Arc<RandomAccessFile>
vasi
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc<RandomAccessFile>is useful because it can be cloned, andReadAtandSizeare not mutating operations.SizeCursor<Arc<RandomAccessFile>>can be cloned and shared across threads and also act like a file with a mutable seek position.A more specific example is creating a
zip::ZipArchive<SizeCursor<Arc<RandomAccessFile>>>instance and cloning a copy per thread.https://docs.rs/zip/1.1.4/zip/read/struct.ZipArchive.html