fix: sidebar preferences fixed

[mynetfan]

Description

修复侧边栏偏好在侧边导航模式下不应该被禁用的问题

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Bug Fixes
  • Improved side navigation mode detection by incorporating header sidebar navigation layout into the evaluation criteria.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/preferences/src/use-preferences.ts

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request modifies the isSideMode computed property in the use-preferences.ts file. The change involves expanding the logical condition for determining the side navigation mode by incorporating isHeaderSidebarNav.value. This adjustment enhances the criteria for evaluating the side mode, specifically considering the header sidebar navigation layout while maintaining the overall structure of the usePreferences function.

Changes

File	Change Summary
packages/@core/preferences/src/use-preferences.ts	Modified isSideMode computed property to include isHeaderSidebarNav.value in its condition

Possibly related PRs

• fix: header logo may not be collapsed in header-sidebar-nav layout #5274: Introduces new computed properties related to isSideMode in use-preferences.ts
• fix: breadcrumb setting not valid for header-sidebar-nav layout #5275: Modifies breadcrumb settings to incorporate isHeaderSidebarNav
• fix: header-mixed layout side-menu active #5265: Updates sidebar menu logic in layout.vue
• feat: new layout sidebar nav with full header #5270: Adds a new layout type with header-sidebar-nav

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

Poem

🐰 A sidebar's dance, a mode so bright
Logic twirled with header's might
Preferences computed, just right
Navigation flows with new insight
Code rabbit hops with pure delight! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9dc613 and 91e7609.

📒 Files selected for processing (1)

• packages/@core/preferences/src/use-preferences.ts (1 hunks)

🔇 Additional comments (1)

packages/@core/preferences/src/use-preferences.ts (1)

114-115: Great addition to cover the header-sidebar-nav layout.

This ensures that the side mode also includes scenarios where the layout is set to header-sidebar-nav. Please verify that all references to isSideMode have been tested to confirm that the sidebar preferences remain enabled in this layout.

✅ Verification successful

isSideMode implementation is correctly handling the header-sidebar-nav layout

Based on the search results, I can verify that the isSideMode computed property is properly implemented and used consistently across the codebase:

1. In @core/preferences/src/use-preferences.ts, isSideMode correctly includes all sidebar-related layouts including isHeaderMixedNav.
2. The property is used appropriately in the layout components:
   • preferences-drawer.vue uses it to control sidebar-related preferences
   • vben-layout.vue uses it for layout-specific rendering logic like sidebar visibility, logo placement, and header width

The implementation ensures that sidebar preferences remain enabled and functional for all sidebar-related layouts, including the header-sidebar-nav layout.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify references to `isSideMode` and check usage in tests or implementation.

# Look for test references of isSideMode if any exist:
rg -A 5 "isSideMode"

# Look for references to ensure isSideMode is used where expected:
rg -A 5 "isSideMode"

Length of output: 10699

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 91e7609

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR