Reject binary ops where the source is an uninitialized register (#740)

Signed-off-by: Alan Jowett <[email protected]>

src/assertions.cpp

@@ -192,17 +192,13 @@ class AssertExtractor {
     }
 
     vector<Assert> operator()(const Atomic& ins) const {
-        vector<Assert> res;
-        res.emplace_back(TypeConstraint{ins.access.basereg, TypeGroup::pointer});
-        res.emplace_back(
-            ValidAccess{ins.access.basereg, ins.access.offset, Imm{static_cast<uint32_t>(ins.access.width)}, false});
-        if (ins.op == Atomic::Op::CMPXCHG) {
-            // The memory contents pointed to by ins.access will be compared
-            // against the value of the ins.valreg register.  Only numbers are
-            // supported.
-            res.emplace_back(TypeConstraint{ins.valreg, TypeGroup::number});
-        }
-        return res;
+
+        return {
+            Assert{TypeConstraint{ins.valreg, TypeGroup::number}},
+            Assert{TypeConstraint{ins.access.basereg, TypeGroup::pointer}},
+            Assert{ValidAccess{ins.access.basereg, ins.access.offset, Imm{static_cast<uint32_t>(ins.access.width)},
+                               false}},
+        };
     }
 
     vector<Assert> operator()(const Un ins) const { return {Assert{TypeConstraint{ins.dst, TypeGroup::number}}}; }
@@ -246,7 +242,14 @@ class AssertExtractor {
             }
             return {Assert{TypeConstraint{ins.dst, TypeGroup::number}}};
         }
-        default: return {Assert{TypeConstraint{ins.dst, TypeGroup::number}}};
+        // For all other binary operations, the destination register must be a number and the source must either be an immediate or a number.
+        default:
+            if (const auto src = std::get_if<Reg>(&ins.v)) {
+                return {Assert{TypeConstraint{ins.dst, TypeGroup::number}},
+                        Assert{TypeConstraint{*src, TypeGroup::number}}};
+            } else {
+                return {Assert{TypeConstraint{ins.dst, TypeGroup::number}}};
+            }
         }
         assert(false);
     }

src/test/test_yaml.cpp

@@ -39,5 +39,6 @@ YAML_CASE("test-data/sext.yaml")
 YAML_CASE("test-data/shift.yaml")
 YAML_CASE("test-data/stack.yaml")
 YAML_CASE("test-data/subtract.yaml")
+YAML_CASE("test-data/uninit.yaml")
 YAML_CASE("test-data/unop.yaml")
 YAML_CASE("test-data/unsigned.yaml")