Address linter / compiler warnings #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarg
commented
Sep 22, 2023
|
@dthaler any idea why does the Windows CI fail? |
Signed-off-by: Elazar Gershuni <[email protected]>
elazarg
force-pushed
the
patch
branch
2 times, most recently
from
ff31da6 to
57e38e2
Compare
The CICD log says:
Looks like this is somehow due to the changes in CMakeLists.txt |
dthaler
reviewed
Sep 22, 2023
Signed-off-by: Elazar Gershuni <[email protected]>
dthaler
approved these changes
Sep 22, 2023
dthaler
added a commit
to dthaler/ebpf-verifier
that referenced
this pull request
Dec 11, 2023
The elfio line is due to a change in bpf_conformance The execute_progress line is because a build error has been there since vbpf#519 where https://github.com/vbpf/ebpf-verifier/actions/runs/6275811448/job/17044135123 for example shows (starting at line 27 in the log): Unknown command: 'ARGS' NuGet.Commands.CommandException: Unknown command: 'ARGS' at NuGet.CommandLine.CommandManager.GetCommand(String commandName) at NuGet.CommandLine.CommandLineParser.ParseCommandLine(IEnumerable`1 commandLineArgs) at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args) Feeds used: https://api.nuget.org/v3/index.json C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\ [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html) should not have ARGS whereas [exec_program](https://cmake.org/cmake/help/latest/command/exec_program.html) does. Signed-off-by: Dave Thaler <[email protected]>
dthaler
added a commit
to dthaler/ebpf-verifier
that referenced
this pull request
Dec 22, 2023
The elfio subdirectory addition is due to a change in bpf_conformance The execute_progress line change is because a build error has been there since vbpf#519 where https://github.com/vbpf/ebpf-verifier/actions/runs/6275811448/job/17044135123 for example shows (starting at line 27 in the log): Unknown command: 'ARGS' NuGet.Commands.CommandException: Unknown command: 'ARGS' at NuGet.CommandLine.CommandManager.GetCommand(String commandName) at NuGet.CommandLine.CommandLineParser.ParseCommandLine(IEnumerable`1 commandLineArgs) at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args) Feeds used: https://api.nuget.org/v3/index.json C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\ [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html) should not have ARGS whereas [exec_program](https://cmake.org/cmake/help/latest/command/exec_program.html) does. Signed-off-by: Dave Thaler <[email protected]>
elazarg
pushed a commit
that referenced
this pull request
Dec 24, 2023
The elfio subdirectory addition is due to a change in bpf_conformance The execute_progress line change is because a build error has been there since #519 where https://github.com/vbpf/ebpf-verifier/actions/runs/6275811448/job/17044135123 for example shows (starting at line 27 in the log): Unknown command: 'ARGS' NuGet.Commands.CommandException: Unknown command: 'ARGS' at NuGet.CommandLine.CommandManager.GetCommand(String commandName) at NuGet.CommandLine.CommandLineParser.ParseCommandLine(IEnumerable`1 commandLineArgs) at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args) Feeds used: https://api.nuget.org/v3/index.json C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\ [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html) should not have ARGS whereas [exec_program](https://cmake.org/cmake/help/latest/command/exec_program.html) does. Signed-off-by: Dave Thaler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.