Accessibility Shift-Left Implementation #197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest')) | ||
| enabled: true | ||
| inputs: | ||
| baselineFile: "$(Build.SourcesDirectory)/baselines/vcpkg.github.io.baseline" |
There was a problem hiding this comment.
I don't think we should be checking in a txt file for this. Can this point to a tmp file go be uploaded to GHA as an artifact?
There was a problem hiding this comment.
I change my mind here. I think checking the file in is fine if the file represents "known" issues. I.e., the PR will fail if there are new issues that don't exist in the baseline file.
| enabled: true | ||
| inputs: | ||
| baselineFile: "$(Build.SourcesDirectory)/baselines/vcpkg.github.io.baseline" | ||
| url: "https://vcpkg.io/en/" |
There was a problem hiding this comment.
This should point to the generated files, not the live site since this is meant to catch accessibility bugs in PRs.
| baselineFile: "$(Build.SourcesDirectory)/baselines/vcpkg.github.io.baseline" | ||
| url: "https://vcpkg.io/en/" | ||
| inputUrls: | | ||
| https://vcpkg.io/en/packages |
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't like the idea of checking in a file for this purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility Shift-Left Implementation