Make audio funcs return errors instead of ints; add tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqiank
pushed a commit
that referenced
this pull request
Jul 22, 2015
Make audio funcs return errors instead of ints; add tests
|
I changed AudioCVT.Buf into a method returning a slice. The length is equal to AudioCVT.LenCVT while the capacity is equal to AudioCVT.Len * AudioCVT.LenMult. Hopefully it works for everyone. |
|
OK, I'll look into testing that. |
|
Hm, there needs to be a way to set the buffer. There aren't any API functions that return an AudioCVT; the typical workflow involving that struct looks like the example at https://wiki.libsdl.org/SDL_AudioCVT. |
|
You should be able to set it normally as you would on a slice. |
neputevshina
pushed a commit
to neputevshina/go-sdl2
that referenced
this pull request
Nov 13, 2024
Make audio funcs return errors instead of ints; add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to add tests for ConvertAudio(), but I noticed that the AudioCVT struct's Buf field uses a *uint8 instead of a []byte as well. Not sure what the best fix for that is, since the current code relies on the struct being binary-compatible with C.SDL_AudioCVT.