Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttf: binded TTF_FontFaceStyleName in sdl_ttf.go #553

Merged
merged 1 commit into from
Feb 2, 2023
Merged

ttf: binded TTF_FontFaceStyleName in sdl_ttf.go #553

merged 1 commit into from
Feb 2, 2023

Conversation

SimpleClips
Copy link
Contributor

Binded TTF_FontFaceStyleName to FaceStyleName() on the Font struct. Added a stub for SDL 2.0.0 support (TTF_FontFaceStyleName was not supported until version 2.0.12).

#552

@SimpleClips
Copy link
Contributor Author

Upon further inspection, TTF_FontFaceStyleName appears to have been added in development of version 2.0.4 despite what the wiki says at the time I wrote that commit. In addition, any version older than that seem to be missing SDL_TTF_VERSION_ATLEAST which the stub function's conditional compilation depends on. Not to mention I get other compile errors with any version of SDL_ttf older than 2.0.10.

Should the stub function be removed or improved with a more version compatible conditional compilation?

@veeableful
Copy link
Contributor

Hi @SimpleClips, thanks for the pull request! Perhaps this can be merged first and we can create additional PR if needed for older versions of SDL2_ttf?

Binded TTF_FontFaceStyleName to FaceStyleName() on the Font struct.
Note: TTF_FontFaceStyleName was not supported until SDL_ttf 2.0.4.
@SimpleClips
Copy link
Contributor Author

Good point. I amended my commit to remove the stub function since it wouldn't have any meaningful benefit in its current state.

@veeableful veeableful merged commit d92a98e into veandco:master Feb 2, 2023
veeableful pushed a commit that referenced this pull request Feb 2, 2023
Binded TTF_FontFaceStyleName to FaceStyleName() on the Font struct.
Note: TTF_FontFaceStyleName was not supported until SDL_ttf 2.0.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants