You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -76,6 +77,7 @@ Create a `manifest.json` file includes app details.
- `isVeWorldSupported` is **required**, set this to true if your dApp supports the VeWorld browser extension, enabling its use within the VeWorld mobile wallet. Your dApp will then be listed in the dApp section of the VeWorld mobile discovery.
- `repo` is _optional_, and must be a fully-qualified URL.
- `contracts` is _optional_, should be **_an array_** and **_lower cases_** if provided
- `veBetterDaoId` is **required** for VeBetterDAO DApps
There is one last stuff to work with, which is to update validation script for the new filed. I would appreciate if you can work on that, if you don't have bandwidth I am happy to help.
@libotony I can work on the validation script, but I'm not sure about the specific validation rules required for the VeBetterDAO ID. Can you help me with this??
Maybe something like this:
function isValid(id: string) { const re = /^0x[a-fA-F0-9]{64}$/; return re.test(hash); }
@libotony I can work on the validation script, but I'm not sure about the specific validation rules required for the VeBetterDAO ID. Can you help me with this??
Maybe something like this:
function isValid(id: string) { const re = /^0x[a-fA-F0-9]{64}$/; return re.test(hash); }
After checking the code, seems easy, let me do a quick commmit.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.