-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx pool tests #636
Tx pool tests #636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 53.89% 54.73% +0.83%
==========================================
Files 179 179
Lines 20665 20665
==========================================
+ Hits 11138 11311 +173
+ Misses 8703 8522 -181
- Partials 824 832 +8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: libotony <[email protected]>
Co-authored-by: libotony <[email protected]>
Co-authored-by: libotony <[email protected]>
By the way regarding the empty lines its probably cause by |
I am also using vscode plus go language plugin, it does not add new lines of every new function but accepts one empty line. |
BTW, the tests are failing since |
@libotony It was easier for me to create a new PR from scratch. I added your suggestions refactoring the
NewDevnet
function to take a timestamp argument instead of duplicating it. I also used theCreateTemp
function in our test cases as you suggested. Code coverage is above 80% in this PR.