-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction signer #850
Merged
Merged
+246
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #850 +/- ##
==========================================
- Coverage 62.65% 62.63% -0.03%
==========================================
Files 208 209 +1
Lines 18926 18952 +26
==========================================
+ Hits 11858 11870 +12
- Misses 5970 5982 +12
- Partials 1098 1100 +2 ☔ View full report in Codecov by Sentry. |
otherview
force-pushed
the
pedro/enhance_tx_builder
branch
from
September 16, 2024 15:06
7473cba
to
f07dc43
Compare
otherview
force-pushed
the
pedro/enhance_tx_builder
branch
from
September 24, 2024 13:16
8a927bf
to
fb481d2
Compare
darrenvechain
previously approved these changes
Sep 26, 2024
libotony
reviewed
Sep 30, 2024
libotony
reviewed
Sep 30, 2024
libotony
reviewed
Sep 30, 2024
libotony
reviewed
Sep 30, 2024
libotony
reviewed
Sep 30, 2024
Co-authored-by: libotony <[email protected]>
libotony
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seems to be a lot of repetition around the build and the signing of transactions.
Most recognizable by the fact that different tests have built different helpers to make these operations faster.
This PR enhances the tx package to help in this case:
MustSignTx(tx *Transaction, pk *ecdsa.PrivateKey) *Transaction
MustCustomSignTx(sign SignFunction, tx *Transaction, pk *ecdsa.PrivateKey) *Transaction
SignTx(tx *Transaction, pk *ecdsa.PrivateKey) (*Transaction, error)
CustomSignTx(sign SignFunction, tx *Transaction, pk *ecdsa.PrivateKey) (*Transaction, error)
DelegatorSignTx(tx *Transaction, pk *ecdsa.PrivateKey) (*Transaction, error)
CustomDelegatorSignTx(sign SignFunction, tx *Transaction, pk *ecdsa.PrivateKey) (*Transaction, error)
Fixes # (issue)
Type of change
Checklist: