Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update builtin generation #896

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Nov 26, 2024

Description

This PR makes it easier to compile the builtin contracts. Its quite difficult to get solc v0.4.24 setup so this change utilises docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner November 26, 2024 12:30
@darrenvechain darrenvechain marked this pull request as draft November 26, 2024 12:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.63%. Comparing base (ae97fba) to head (683389b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   60.63%   60.63%           
=======================================
  Files         215      215           
  Lines       23105    23105           
=======================================
  Hits        14009    14009           
  Misses       7947     7947           
  Partials     1149     1149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenvechain darrenvechain marked this pull request as ready for review November 26, 2024 16:36
@libotony
Copy link
Member

We should make a backup of ethereum/solc:0.4.24 somewhere.

@darrenvechain darrenvechain merged commit 9eec212 into master Nov 29, 2024
15 checks passed
@darrenvechain darrenvechain deleted the chore/update-builtin-gen branch November 29, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants