Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document wallet connect #65

Merged
merged 12 commits into from
Nov 10, 2023
Merged

Document wallet connect #65

merged 12 commits into from
Nov 10, 2023

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Nov 9, 2023 •
edited
Loading

I think this package is overkill. We should move it to a wallet-connect directory of the wallet-kit

@darrenvechain darrenvechain requested a review from a team as a code owner November 9, 2023 09:55
@darrenvechain darrenvechain mentioned this pull request Nov 9, 2023
Closed
@darrenvechain darrenvechain enabled auto-merge (squash) November 9, 2023 10:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@darrenvechain darrenvechain merged commit eb64a9f into main Nov 10, 2023
2 checks passed
@darrenvechain darrenvechain deleted the document-wallet-connect branch December 5, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidecarpini davidecarpini davidecarpini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenvechain @davidecarpini