Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module "imp" was deprecated in python 3.12 #107

Open
david-geiger opened this issue Mar 28, 2024 · 2 comments
Open

module "imp" was deprecated in python 3.12 #107

david-geiger opened this issue Mar 28, 2024 · 2 comments
Labels
bug

Comments

@david-geiger
Copy link
Contributor

The module "imp" should be replaced by 'importlib" as it was deprecated in python3.12.

This proposed patch fixes this:

0001-Migrate-from-imp-to-importlib.patch.txt
@BenjamenMeyer
Copy link
Member

@david-geiger feel free to submit a PR; otherwise I'll file it when I get a chance. I'd rather see you get the credit though.

@david-geiger
Copy link
Contributor Author

Ok, I'll do it :)

@david-geiger david-geiger mentioned this issue Apr 6, 2024
Closed
david-geiger added a commit to david-geiger/Assets-Production that referenced this issue Apr 21, 2024
@david-geiger
Migrate from imp to importlib
30844a5 
- the 'imp' module is deprecated from years and now Python 3.12 finally
  drops completely support of 'imp' module.
- fix for vegastrike#107
This was referenced Apr 21, 2024
Open
Open
david-geiger added a commit to david-geiger/Assets-Production that referenced this issue Apr 21, 2024
@david-geiger
Migrate from imp to importlib
9006c54 
- the 'imp' module is deprecated from years and now Python 3.12 finally
  drops completely support of 'imp' module.
- fix for vegastrike#107
@david-geiger david-geiger mentioned this issue Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenjamenMeyer @david-geiger