Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from imp to importlib #108

Closed
wants to merge 1 commit into from
Closed

Migrate from imp to importlib #108

wants to merge 1 commit into from

Conversation

david-geiger
Copy link
Contributor

- the 'imp' module is deprecated from years and now Python 3.12 finally
  drops completely support of 'imp' module.
@stephengtuggy
Copy link
Contributor

@david-geiger Thanks for the pull request. Yes, I think this change is very much needed. It looks good to me; however, we will probably need to test the gameplay with your changes before we can fully approve and merge them.

Thanks again. More contributors are always welcome.

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We should be able to get this play tested quickly.

We're also trying to get our 0.9.0 release out the door; would you please also open a PR against our 0.9.x branch with the same changes?

@david-geiger
Copy link
Contributor Author

Thanks for the PR. We should be able to get this play tested quickly.

We're also trying to get our 0.9.0 release out the door; would you please also open a PR against our 0.9.x branch with the same changes?

I don't really know how to do a PR for a separate branch.

@stephengtuggy
Copy link
Contributor

Thanks for the PR. We should be able to get this play tested quickly.
We're also trying to get our 0.9.0 release out the door; would you please also open a PR against our 0.9.x branch with the same changes?

I don't really know how to do a PR for a separate branch.

In the screen that you get when you click Create Pull Request, you can choose which branch (and fork) to target for merging into. You can use the same source branch, but target a different branch, in a separate PR that way.

Let us know if you can't figure it out. Thanks!

@david-geiger david-geiger closed this by deleting the head repository Apr 21, 2024
@BenjamenMeyer
Copy link
Member

Please reopen this as it fits against our master (0.10.x) branch AS-IS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants