Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some of the errors encountered in the fragment programs and vertex programs on macOS #112

Merged
merged 4 commits into from
May 3, 2024
Merged

Fix some of the errors encountered in the fragment programs and vertex programs on macOS #112

merged 4 commits into from
May 3, 2024

Conversation

stephengtuggy
Copy link
Contributor

Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.

Please answer the following:

Code Changes:

Issues:
N/A

Purpose:

  • What is this pull request trying to do? Like the title says, fix some of the errors I've been running into on Mac. Especially in the fragment programs and vertex programs.
  • What release is this for? 0.9.x/0.10.x
  • Is there a project or milestone we should apply this to? 0.9.x, preferably

@stephengtuggy stephengtuggy self-assigned this May 1, 2024
@stephengtuggy stephengtuggy requested a review from a team May 1, 2024 22:30
BenjamenMeyer
BenjamenMeyer approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@stephengtuggy stephengtuggy merged commit 271e91b into vegastrike:master May 3, 2024
13 checks passed
@stephengtuggy stephengtuggy deleted the textureLod branch May 3, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

Assignees

@stephengtuggy stephengtuggy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephengtuggy @BenjamenMeyer