A python script to generate ship view #130
Conversation
|
Hi there! Before building this, I see that you have to merge in the change where the config.json is installed into this branch, and so resolve that conflict. It is a bit tedious, but makes things easier down the line. I don't see how the game engine is taking advantage of this new python script. It that to be implemented at a later stage when this is in master? |
There was a problem hiding this comment.
Approving to get it in; but I'd like to see the File open and json.load move to the C++/engine side so we can present a more consistent interface to the game; unless of course we're expecting that config.json is a pure Game Asset - in which case we should go with option a in the comment and expose a good method for knowing that from the VS side - but all that can be evolution of this PR.
| with open('config.json', 'r') as file: | ||
| data = json.load(file) | ||
| non_combat_speed_multiplier = data['components']['drive']['non_combat_mode_multiplier'] | ||
| megajoules_multiplier = data['constants']['megajoules_multiplier'] |
There was a problem hiding this comment.
since config.json would have to be in a specific place we need to either:
(a) define a working directory for the active "game"
(b) expose these as Python Objects instead of making each script load it if it wants access. This would eliminate the open and json.load steps; and we'd have to define the interface - either as a pure Python Dictionary/Object or as something else. A first step might be just having a load method that would load the contents and return the data object like you have above.
I'd rather b between the two.
There was a problem hiding this comment.
Thinking more about this...option a might actually be a better solution for game asset data. But let's evolve the conversation on this beyond just this PR.
python/base_computer/ship_view.py
Outdated
| non_combat_speed_multiplier = data['components']['drive']['non_combat_mode_multiplier'] | ||
| megajoules_multiplier = data['constants']['megajoules_multiplier'] | ||
|
|
||
| with open('units/units.json', 'r') as file: |
python/base_computer/ship_view.py
Outdated
|
|
||
| t = get_ship_description(llama_begin) | ||
| t = t.replace('#n#','\n') | ||
| print(t) |
There was a problem hiding this comment.
if this is for testing, then it probably should be wrapped. Usually if its a test to be called on the commandline (e.g just see the script output) then using:
if __name__ == "__main__":
# python blockwould be appropriate. If we can control the name and calling it in a test, then may be we call it __vegastrike_test_main__ instead...but I doubt that'd we'd have that control.
as per comments
This PR starts moving a lot of the ship view and later similar code from base_computer.cpp to python. The script can be run independently and pull data from units.json/llama.begin.
This works with vegastrike/Vega-Strike-Engine-Source#899.
Please answer the following:
Code Changes:
Issues: